Files that changed from the base of the PR and between 002d277 and 10e1ac9.

• x/delegation/types/query.pb.go is excluded by !**/*.pb.go
• x/delegation/types/query.pb.gw.go is excluded by !**/*.pb.gw.go
• x/deposit/types/query.pb.gw.go is excluded by !**/*.pb.gw.go
• x/operator/types/query.pb.go is excluded by !**/*.pb.go
• x/operator/types/query.pb.gw.go is excluded by !**/*.pb.gw.go
• x/operator/types/tx.pb.go is excluded by !**/*.pb.go
• x/oracle/types/params.pb.go is excluded by !**/*.pb.go
• x/reward/types/query.pb.gw.go is excluded by !**/*.pb.gw.go
• x/slash/types/query.pb.gw.go is excluded by !**/*.pb.gw.go

• precompiles/avsTask/task_test.go (1 hunks)
• proto/exocore/delegation/v1/query.proto (3 hunks)
• proto/exocore/operator/v1/query.proto (2 hunks)
• proto/exocore/operator/v1/tx.proto (2 hunks)
• x/assets/keeper/operator_asset.go (3 hunks)
• x/avs/keeper/avs_test.go (6 hunks)
• x/delegation/client/cli/query.go (2 hunks)
• x/delegation/keeper/grpc_query.go (1 hunks)
• x/operator/client/cli/query.go (2 hunks)
• x/operator/keeper/abci.go (2 hunks)
• x/operator/keeper/grpc_query.go (1 hunks)
• x/operator/keeper/keeper.go (2 hunks)
• x/operator/keeper/operator_slash_state.go (2 hunks)
• x/operator/keeper/opt.go (1 hunks)
• x/operator/keeper/opt_test.go (3 hunks)
• x/operator/keeper/slash.go (5 hunks)
• x/operator/keeper/slash_test.go (1 hunks)
• x/operator/keeper/usd_value.go (1 hunks)
• x/operator/module.go (1 hunks)
• x/operator/types/codec.go (2 hunks)
• x/operator/types/errors.go (1 hunks)
• x/operator/types/expected_keepers.go (4 hunks)

• precompiles/avsTask/task_test.go
• x/operator/keeper/opt.go
• x/operator/module.go
• x/operator/types/codec.go

x/delegation/keeper/grpc_query.go (2)

22-31: The implementation of QueryUndelegations correctly retrieves undelegation records based on staker ID and asset ID. Ensure that proper indexing is in place for efficient retrieval of these records.

---

33-42: The implementation of QueryUndelegationsByHeight appears correct. However, consider renaming the function to GetPendingUndelegationRecords as suggested by leonz789 for clarity on its functionality.
[REFACTOR_SUGGESTion]

x/operator/types/errors.go (1)

95-97: The error ErrInvalidSlashPower is well-defined and follows the naming conventions and error registration pattern of the module.

x/operator/keeper/keeper.go (2)

6-8: The new imports sdkmath and stakingtypes are appropriate for the functionalities being introduced in the slashing logic.

---

74-79: The new function SlashWithInfractionReason provides detailed slashing logic, allowing for more granular control over slashing conditions based on specific infractions. Ensure that the parameters and return types are correctly documented in the function comments.

x/operator/keeper/abci.go (1)

22-66: The CalculateUSDValueForOperator function has been significantly refactored to accommodate the new slashing logic. The detailed implementation handles both the normal and slashing scenarios. Ensure that the error handling is robust and that all edge cases are considered, especially in the asset price retrieval and calculation sections.

x/assets/keeper/operator_asset.go (1)

Line range hint 99-123: The addition of the isUpdate parameter in the IteratorAssetsForOperator function is a good use of conditional logic to control the flow of data updates. This change allows the function to be used both for retrieving data and updating state based on the condition, which enhances its reusability. Ensure that all callers of this function are updated to pass the new parameter.

proto/exocore/delegation/v1/query.proto (1)

Line range hint 85-139: The addition of new protobuf messages and RPCs (UndelegationsReq, UndelegationsByHeightReq, and their corresponding RPCs) enhances the querying capabilities for undelegations. This allows clients to fetch undelegation records either by staker and asset ID or by block height, which is crucial for auditing and tracking purposes. Ensure that the corresponding server-side implementations handle these queries efficiently and securely.

x/delegation/client/cli/query.go (2)

31-32: LGTM! The addition of these commands enhances the query capabilities for undelegations.

---

145-175: The function QueryUndelegationsByHeight is well-implemented with appropriate error handling and pagination support.

x/operator/types/expected_keepers.go (1)

26-26: The addition of the isUpdate parameter in IteratorAssetsForOperator is a significant change. Ensure that all usages of this function are updated to pass this new parameter.

Verification successful

---

All usages of the IteratorAssetsForOperator function have been updated to include the new isUpdate parameter. Here are the relevant locations:

• x/operator/keeper/slash.go
• x/operator/keeper/abci.go
• x/assets/keeper/operator_asset.go

Scripts executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Ensure all calls to `IteratorAssetsForOperator` pass the `isUpdate` parameter.

# Test: Search for function usage across the codebase. Expect: All calls include the new parameter.
rg --type python $'IteratorAssetsForOperator'

Length of output: 75

---

---

Script:

#!/bin/bash
# Description: Ensure all calls to `IteratorAssetsForOperator` pass the `isUpdate` parameter.

# Test: Search for function usage across the codebase. Expect: All calls include the new parameter.
rg --type go 'IteratorAssetsForOperator'

Length of output: 859

x/operator/keeper/grpc_query.go (3)

176-185: The implementation of QueryOperatorUSDValue is correct. Ensure the GetOperatorUSDValue function properly handles the new AddressInfo structure.

---

187-196: The QueryAVSUSDValue function correctly retrieves USD values for AVS addresses. Verify that GetAVSUSDValue supports all expected AVS addresses.

---

198-207: QueryOperatorSlashInfo successfully retrieves slash information. Ensure that AllOperatorSlashInfo is thoroughly tested to handle various edge cases.

x/avs/keeper/avs_test.go (4)

117-117: The test case for registering an operator when AVS is not registered is good. Ensure that the error handling is robust and provides clear messages for different failure scenarios.

---

136-136: The test case for registering AVS looks comprehensive. Verify that all fields of AVSInfo are correctly persisted and retrieved.

---

159-159: Testing for duplicate registration is important. Ensure that the system correctly prevents duplicate entries without causing any data integrity issues.

---

168-168: The test for duplicate deregistration is essential. Make sure the error handling is consistent and informative.

x/operator/keeper/operator_slash_state.go (4)

33-33: Please rename the variable to slashContract for clarity.

---

38-38: Consider wrapping the error with more context about the mismatch between expected and actual slash contracts.

---

41-41: Consider wrapping the error to provide more context regarding the issue.

---

69-87: The function AllOperatorSlashInfo effectively retrieves all slash information for a given operator and AVS. It handles potential errors well and uses a map to store results, which is appropriate for this use case. However, ensure that the key parsing and error handling are robust and tested, especially since parsing operations can be error-prone.

x/operator/client/cli/query.go (2)

30-32: The addition of new CLI commands QueryOperatorUSDValue, QueryAVSUSDValue, and QueryOperatorSlashInfo enhances the module's functionality by allowing users to query USD values and slash information directly from the CLI. This aligns well with the PR's objectives to add missed RPC and CLI functionalities.

---

233-320: The implementation of the QueryOperatorUSDValue, QueryAVSUSDValue, and QueryOperatorSlashInfo commands are correctly structured and follow the conventions of the Cosmos SDK for CLI commands. Each command correctly handles errors and uses the appropriate request structures. Ensure that the command descriptions are clear and that the parameters are appropriately validated in future updates.

x/operator/keeper/usd_value.go (1)

86-90: The check for whether an operator has opted out of the AVS before returning the USD value is a crucial addition for ensuring that only active participants are considered in financial calculations. This aligns with the best practices of checking conditions before performing operations.

proto/exocore/operator/v1/query.proto (2)

34-40: The addition of the AddressInfo message consolidates the operator and AVS addresses into a single structure, which simplifies the request structures for other messages. This is a good practice in protocol design to reduce redundancy.

---

213-227: The new RPCs QueryOperatorUSDValue, QueryAVSUSDValue, and QueryOperatorSlashInfo are correctly defined and include appropriate HTTP annotations for REST compatibility. These additions enhance the API's functionality by supporting new types of queries as described in the PR.

proto/exocore/operator/v1/tx.proto (3)

96-109: LGTM. The message SlashFromUndelegation is clearly defined with appropriate field annotations.

---

110-121: LGTM. The message SlashFromAssetsPool is well-structured and the use of custom types and non-nullable fields is consistent with best practices.

---

124-144: The SlashExecutionInfo message is well-defined. However, ensure that the fields slash_proportion and slash_value are used consistently and correctly throughout the system to avoid misinterpretations.

x/operator/keeper/slash.go (4)

36-54: The SlashFromUndelegation function handles the slashing logic correctly by checking if the ActualCompletedAmount is zero before proceeding. This prevents unnecessary calculations and potential errors in cases where there is nothing to slash.

---

57-71: The CheckSlashParameter function correctly validates the SlashEventHeight and the Power fields based on whether it is a dogfood scenario or not. This dual-path validation ensures that the slashing parameters are appropriate for the context they are used in.
[APROVED]

---

Line range hint 159-184: The Slash function integrates various components of the slashing logic into a cohesive operation. It ensures that all parameters are checked, assets are slashed, and the execution information is stored correctly. This function is central to the slashing mechanism and appears to be robust.

---

Line range hint 76-156: The SlashAssets function is well-implemented with detailed and clear logic for slashing assets based on new calculated proportions. However, consider handling edge cases where newSlashProportion might lead to division by zero or other anomalies due to extreme values.

Files that changed from the base of the PR and between 10e1ac9 and 066b0af.

• x/operator/types/query.pb.go is excluded by !**/*.pb.go
• x/operator/types/tx.pb.go is excluded by !**/*.pb.go

• proto/exocore/operator/v1/query.proto (2 hunks)
• proto/exocore/operator/v1/tx.proto (2 hunks)
• x/assets/types/codec.go (1 hunks)
• x/avstask/types/codec.go (1 hunks)
• x/delegation/client/cli/query.go (2 hunks)
• x/delegation/keeper/abci.go (2 hunks)
• x/delegation/keeper/delegation_op_test.go (2 hunks)
• x/delegation/keeper/grpc_query.go (1 hunks)
• x/delegation/keeper/un_delegation_state.go (5 hunks)
• x/delegation/types/codec.go (1 hunks)
• x/delegation/types/keys.go (3 hunks)
• x/deposit/types/codec.go (1 hunks)
• x/operator/client/cli/query.go (2 hunks)
• x/operator/keeper/abci.go (2 hunks)
• x/operator/keeper/grpc_query.go (1 hunks)
• x/operator/keeper/keeper.go (2 hunks)
• x/operator/keeper/operator_slash_state.go (5 hunks)
• x/operator/keeper/slash.go (4 hunks)
• x/operator/types/codec.go (2 hunks)
• x/operator/types/general.go (1 hunks)
• x/reward/types/codec.go (1 hunks)
• x/slash/types/codec.go (1 hunks)

• x/assets/types/codec.go
• x/delegation/types/codec.go
• x/deposit/types/codec.go
• x/reward/types/codec.go
• x/slash/types/codec.go

• proto/exocore/operator/v1/query.proto
• x/delegation/client/cli/query.go
• x/delegation/keeper/grpc_query.go
• x/operator/keeper/abci.go
• x/operator/keeper/grpc_query.go
• x/operator/keeper/keeper.go
• x/operator/keeper/operator_slash_state.go
• x/operator/keeper/slash.go
• x/operator/types/codec.go

x/operator/types/general.go (2)

11-15: This struct definition for OperatorUSDValue is clean and straightforward. It effectively encapsulates the different types of USD values associated with an operator.

---

17-27: The SlashInputInfo struct is comprehensive and appears to cover all necessary fields for handling slash events. However, ensure that the SlashID field is consistently used across all related modules to avoid discrepancies.

x/avstask/types/codec.go (1)

13-16: The comment here provides a clear explanation of the intended use of ModuleCdc. It's good practice to explicitly state where a global codec should be used, especially to prevent misuse in serialization contexts.

x/delegation/types/keys.go (2)

Line range hint 39-61: The addition of prefixPendingUndelegations and the corresponding key utility functions are well-implemented. These changes should help in managing undelegation records more efficiently. Ensure that the new key prefix does not overlap with existing prefixes to avoid data conflicts.

---

121-121: The function GetPendingUndelegationRecordKey is correctly implemented to generate keys for pending undelegations. This is crucial for tracking undelegations that are not yet processed.

x/delegation/keeper/un_delegation_state.go (1)

Line range hint 17-34: Consider optimizing the repeated calls to prefix.NewStore by storing the stores in the keeper struct.
[REFACTOR_SUGGESTion]
By initializing these stores once in the keeper's constructor, you can avoid the overhead of creating them on each function call, enhancing performance.

proto/exocore/operator/v1/tx.proto (1)

155-166: Review the changes to field types and names in OperatorSlashInfo.

As previously commented, the changes in field types and names could significantly affect serialization and compatibility. Ensure these changes are intentional and documented.

Tools

GitHub Check: break-check

[failure] 155-155:
Field "4" with name "is_vetoed" on message "OperatorSlashInfo" changed option "json_name" from "processedHeight" to "isVetoed".

---

[failure] 155-155:
Field "4" on message "OperatorSlashInfo" changed type from "int64" to "bool".

---

[failure] 155-155:
Field "4" on message "OperatorSlashInfo" changed name from "processed_height" to "is_vetoed".

---

[failure] 157-157:
Field "5" with name "slash_proportion" on message "OperatorSlashInfo" changed option "json_name" from "isVetoed" to "slashProportion".

---

[failure] 157-157:
Field "5" on message "OperatorSlashInfo" changed type from "bool" to "string".

---

[failure] 157-157:
Field "5" on message "OperatorSlashInfo" changed name from "is_vetoed" to "slash_proportion".

---

[failure] 164-164:
Field "6" with name "slash_type" on message "OperatorSlashInfo" changed option "json_name" from "slashProportion" to "slashType".

---

[failure] 164-164:
Field "6" on message "OperatorSlashInfo" changed type from "string" to "uint32".

---

[failure] 164-164:
Field "6" on message "OperatorSlashInfo" changed name from "slash_proportion" to "slash_type".

---

[failure] 166-166:
Field "7" with name "execution_info" on message "OperatorSlashInfo" changed option "json_name" from "slashType" to "executionInfo".

x/delegation/keeper/delegation_op_test.go (2)

Line range hint 244-248: The test TestCompleteUndelegation effectively checks the final state after undelegation is completed. It's good to see that the test ensures no undelegation records remain, which aligns with the expected behavior. This part of the test seems well-implemented and does not require changes.

---

Line range hint 187-192: The test TestUndelegateFrom correctly verifies the undelegation process by checking the state after undelegation. However, ensure that the GetPendingUndelegationRecords method handles edge cases, such as when no records exist or multiple records are pending.

Verification successful

---

The test cases in delegation_op_test.go do cover the scenarios where there are no undelegation records and where there is one undelegation record. The GetPendingUndelegationRecords method handles the edge case of no records by returning an empty slice, which is correctly asserted in the test cases.

Scripts executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify edge case handling in `GetPendingUndelegationRecords`.

# Test: Search for the method usage with different input scenarios.
ast-grep --lang go --pattern $'func (suite *DelegationTestSuite) {
  $$$
  GetPendingUndelegationRecords($_, $_) {
    $$$
  }
  $$$  
}'

Length of output: 138

---

---

Script:

#!/bin/bash
# Locate the definition of `GetPendingUndelegationRecords` method in the codebase
ast-grep --lang go --pattern $'func (dk *DelegationKeeper) GetPendingUndelegationRecords($_, $_) ($$, error) {
  $$$
}' --debug

# Search for the usage of `GetPendingUndelegationRecords` across the codebase to identify different input scenarios
rg 'GetPendingUndelegationRecords'

Length of output: 1116

---

---

Script:

#!/bin/bash
# Locate the definition of `GetPendingUndelegationRecords` method in the codebase
ast-grep --lang go --pattern $'func (dk *DelegationKeeper) GetPendingUndelegationRecords($_, $_) ($$, error) {
  $$$
}' --debug-query

# Display the content of the file containing the method definition
cat x/delegation/keeper/un_delegation_state.go

Length of output: 9290

---

---

Script:

#!/bin/bash
# Verify if the test cases in `delegation_op_test.go` cover scenarios with no records and multiple records

# Search for test cases that call `GetPendingUndelegationRecords` in `delegation_op_test.go`
rg 'GetPendingUndelegationRecords' x/delegation/keeper/delegation_op_test.go

# Display the specific test cases that call `GetPendingUndelegationRecords`
cat x/delegation/keeper/delegation_op_test.go | awk '/GetPendingUndelegationRecords/,/}/'

Length of output: 907

Files that changed from the base of the PR and between 066b0af and 693c2e5.

• proto/exocore/operator/v1/query.proto (2 hunks)

• proto/exocore/operator/v1/query.proto

Files that changed from the base of the PR and between 693c2e5 and 6931786.

• proto/exocore/operator/v1/query.proto (2 hunks)
• x/operator/keeper/abci.go (2 hunks)
• x/operator/keeper/usd_value.go (2 hunks)

• proto/exocore/operator/v1/query.proto
• x/operator/keeper/abci.go
• x/operator/keeper/usd_value.go

Files that changed from the base of the PR and between 6931786 and be3b8e5.

• x/operator/types/query.pb.go is excluded by !**/*.pb.go

• proto/exocore/operator/v1/query.proto (4 hunks)
• x/assets/types/keys.go (1 hunks)
• x/operator/client/cli/query.go (6 hunks)
• x/operator/keeper/abci.go (2 hunks)
• x/operator/keeper/grpc_query.go (2 hunks)

• proto/exocore/operator/v1/query.proto
• x/operator/client/cli/query.go
• x/operator/keeper/abci.go
• x/operator/keeper/grpc_query.go

x/assets/types/keys.go (1)

90-94: Well-implemented function for generating store keys with a trailing slash

The GetJoinedStoreKeyForPrefix function correctly concatenates the given keys with a slash and ensures a trailing slash is added. This implementation is efficient and follows Go best practices for handling strings and slices.